Set JWT auth token "sub" field by basic auth username instead of "account" HTTP GET parameter

SUSE / Portus

Authorization service and frontend for Docker registry (v2)

http://port.us.org/

Apache License 2.0

3k stars 471 forks source link

Set JWT auth token "sub" field by basic auth username instead of "account" HTTP GET parameter #2286

Closed StarGate01 closed 4 years ago

StarGate01 commented 4 years ago

As per the specification and the authors of containerd the account GET parameter when requesting a JWT auth token is invalid (Even though docker-cli does it) and the HTTP basic auth username should be used instead. For example, Docker BuildX via buildkit via containerd does not set this parameter, resulting in Portus being confused.

This pull request fixes this behaviour by using the HTTP auth username.

Signed-off-by: Christoph Honal christoph.honal@web.de

StarGate01 commented 4 years ago

Note: https://github.com/SUSE/Portus/pull/2274 Also fixes this issue.

stale[bot] commented 4 years ago

Thanks for all your contributions! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.