search

SUSE / Portus

Authorization service and frontend for Docker registry (v2)
http://port.us.org/
Apache License 2.0
3k stars 471 forks source link

Github depreciating API warning email #2309

Closed jiningh closed 3 years ago

jiningh commented 4 years ago

Description

I hooked up Github authentication to my registry and everything works just fine. But I got this email from Github so I'm not sure how long it's going to continue to just work fine.

On [redacted] (UTC) your application ([redacted]) used an access token (with the User-Agent Faraday v0.9.2) as part of a query parameter to access an endpoint through the GitHub API.

https://api.github.com/user

Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated.

Depending on your API usage, we'll be sending you this email reminder on a monthly basis.

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

Steps to reproduce

  1. First I did this... Added the following to docker-compose.yml

    • PORTUS_OAUTH_LOCAL_LOGIN_ENABLED=false
    • PORTUS_OAUTH_GITHUB_ENABLED=true
    • PORTUS_OAUTH_GITHUB_CLIENT_ID=[redacted]
    • PORTUS_OAUTH_GITHUB_CLIENT_SECRET=[redacted]
    • PORTUS_OAUTH_GITHUB_ORGANIZATION=[redacted]
    • PORTUS_SIGNUP_ENABLED=false

  2. Then that... Tried logging in with account in and out of organization. Behaves as expected.

  3. And this happened!

Deployment information

Deployment method: how have you deployed Portus? Are you using one of the examples as a base? If possible, could you paste your configuration? (don't forget to strip passwords or other sensitive data!)

Configuration: Basically untouched docker-compose-secure.yml from the examples folder except for the changes above

Portus version: Version: 2.5.0-dev@a1b9f2ebfeb84680a9dcd5629195e4c52815735c

stale[bot] commented 3 years ago

Thanks for all your contributions! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.