search

SUSE / SAPHanaSR

SAP HANA System Replication Resource Agent for Pacemaker Cluster
GNU General Public License v2.0
26 stars 21 forks source link

ATTR_NAME_HANA_FILTER - 3rd value should be variable SAPHanaFilter and not static string #167

Open PeterPitterling opened 1 year ago

PeterPitterling commented 1 year ago

https://github.com/SUSE/SAPHanaSR/blob/03db1cd166469f224996cebc2aeb658dcc007976/ra/SAPHanaTopology#L512

https://github.com/SUSE/SAPHanaSR/blob/03db1cd166469f224996cebc2aeb658dcc007976/ra/SAPHanaTopology#L518-L520

declare -u SAPHanaFilter='ra-act-dec-lpa'

PeterPitterling commented 7 months ago

to be more precise SAPHanaFilter is already declared

declare -u SAPHanaFilter='ra-act-dec-lpa'

use here instead of specifying same string again ATTR_NAME_HANAFILTER=("hana${sid}_glob_filter" "props" "ra-act-dec-lpa") --> ATTR_NAME_HANAFILTER=("hana${sid}_glob_filter" "props" "${SAPHanaFilter}")

fmherschel commented 7 months ago

Still unclear what is the real benefit.

PeterPitterling commented 7 months ago

currently the filter values 'ra-act-dec-lpa' are defined 2times .. the first declaration has no meaning .. if you want to change the default filter you have to change it in the second occurence

ATTR_NAME_HANAFILTER=("hana${sid}glob_filter" "props" "ra-act-dec-lpa")

this is different again for SAPHana and SAPHanaTopology