search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

Add a whitelist for returned events so we only save events that we care about #678

Closed ereslibre closed 5 years ago

ereslibre commented 5 years ago
nanoscopic commented 5 years ago

This change breaks initial node acceptance. The message from salt that is logged of a node being acceptance is not whitelisted, so velum does not detect that a node has been accepted and you cannot continue the install process within Velum. The message type for that needs to be determined and added to this whitelist before further testing can occur.

The missing tag that is needed is 'salt/auth'; particularly the ones with 'act': accept. Adding that tag to the whitelist makes it work ( have tested this ). Please add that tag and resubmit so that the full test suite can be run.

ereslibre commented 5 years ago

I'm trying a slightly different approach. Will report back.

ereslibre commented 5 years ago

The other approach was more intrusive than this one. I have added salt/auth (we can only discriminate by tags in this approach) to the allow list.