search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

cilium: add repo for cilium #695

Closed nirmoy closed 5 years ago

nirmoy commented 5 years ago

note: we dont have any caasp_registry for cilium yet. so this PR wont work now, until we have cilium in caasp_registry.

bergmannf commented 5 years ago

LGTM, but I guess now we have to keep this open until we have a cilium image release in our used registry-values in the devenv or it would break there:

https://github.com/kubic-project/caasp-container-manifests/blob/master/config/registry/registry-config.yaml

nirmoy commented 5 years ago

rebased

nirmoy commented 5 years ago

unrelated error: ++ kubectl --kubeconfig /srv/jenkins/workspace/salt.integration_PR-695/kubeconfig get pods --no-headers --namespace helm-392f5e5e-4a2b-442c-9723-33d134e358d0

helm-392f5e5e-4a2b-442c-9723-33d134e358d0-mariadb-b9846bbfn7492 0/1 Init:ImagePullBackOff 0 44s

INFO: Waiting for pods to enter running state

nirmoy commented 5 years ago

@bergmannf please review again

nirmoy commented 5 years ago

@inercia Thanks, updated the PR, there are two more such references I will add fix for those too grep base_image_url * -R |grep sls pillar/params.sls:pod_infra_container_image: {{ salt.caasp_registry.base_image_url() }}/pause:1.0.0 pillar/cni.sls: image: '{{ salt.caasp_registry.base_image_url() }}/flannel:0.9.1'

spiarh commented 5 years ago

LGTM

jordimassaguerpla commented 5 years ago

@nirmoy @inercia : Is this ready? I see some change request by based on the comments this seems addressed, does it?

nirmoy commented 5 years ago

@jordimassaguerpla its done from my side, I need to create another cleaup PR to remove {{ salt.caasp_registry.base_image_url() }} from flannel and infra container image