search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

Flake8 cleanup backport 3.0 #707

Closed dannysauer closed 5 years ago

dannysauer commented 5 years ago

Backport PRs #567 and #703 to fix flake8 code formatting warnings.

Is a Bugzilla entry required for simple things like this? Tagging no-ref for now.

jordimassaguerpla commented 5 years ago

adding Florian as a reviewer since he was in the initial PR

jordimassaguerpla commented 5 years ago

Sorry I am not familiar with this code to review it myself.

hwoarang commented 5 years ago

Looks like we need https://github.com/kubic-project/salt/pull/706 for flake8 tests to pass on release-3.0

dannysauer commented 5 years ago

Thanks, @hwoarang - I was wondering about that. These two silence flake8 (both direct and from tox) when run on my local machine, but I'm not running "almost EOL" Leap 42 and a python without https like the old Jenkins image. 😂

dannysauer commented 5 years ago

...rebased to include now-merged #706

jordimassaguerpla commented 5 years ago

@dannysauer About the bug... Why do we need to release this to our customers?

stefsuse commented 5 years ago

@jordimassaguerpla This is to get ahead of issues we will see when we update to python3. See the description here https://github.com/kubic-project/salt/pull/567

jordimassaguerpla commented 5 years ago

I don't think we are updating to python3 in the 3.0 branch. I am closing it. Feel free to reopen if you need this to fix a bug.