Closed dannysauer closed 5 years ago
adding Florian as a reviewer since he was in the initial PR
Sorry I am not familiar with this code to review it myself.
Looks like we need https://github.com/kubic-project/salt/pull/706 for flake8 tests to pass on release-3.0
Thanks, @hwoarang - I was wondering about that. These two silence flake8 (both direct and from tox) when run on my local machine, but I'm not running "almost EOL" Leap 42 and a python without https like the old Jenkins image. 😂
...rebased to include now-merged #706
@dannysauer About the bug... Why do we need to release this to our customers?
@jordimassaguerpla This is to get ahead of issues we will see when we update to python3. See the description here https://github.com/kubic-project/salt/pull/567
I don't think we are updating to python3 in the 3.0 branch. I am closing it. Feel free to reopen if you need this to fix a bug.
Backport PRs #567 and #703 to fix flake8 code formatting warnings.
Is a Bugzilla entry required for simple things like this? Tagging no-ref for now.