Closed MaximilianMeister closed 5 years ago
This can only be merged when we updated to kubernetes 1.11
Needs a rebase on top of #710 for passing salt.tests.
We would have to check, but the previous annotation wasn't actually used, and I'm not sure about the new annotation. I saw sometimes ago that these patches were necessary:
Since ExperimentalCriticalPodAnnotation
is false
by default as per https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/.
We would have to check, but the previous annotation wasn't actually used, and I'm not sure about the new annotation. I saw sometimes ago that these patches were necessary:
681
682
Since
ExperimentalCriticalPodAnnotation
isfalse
by default as per https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/.
good catch. this seems very likely. i think the best for now is to get those PR's merged
now that we are on 1.13 we need to consider this
@MaximilianMeister kube-flannel
pods would also require this annotation
kube-flannel
pods would also require this annotation
@lcavajani thanks for the hint. updated
https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
bsc#1122783
Signed-off-by: Maximilian Meister mmeister@suse.de