[k8s 1.13][bsc#1122783] update critical pod configuration

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster

Apache License 2.0

64 stars 29 forks source link

[k8s 1.13][bsc#1122783] update critical pod configuration #708

Closed MaximilianMeister closed 5 years ago

MaximilianMeister commented 5 years ago

https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/

bsc#1122783

Signed-off-by: Maximilian Meister mmeister@suse.de

MaximilianMeister commented 5 years ago

This can only be merged when we updated to kubernetes 1.11

ereslibre commented 5 years ago

Needs a rebase on top of #710 for passing salt.tests.

ereslibre commented 5 years ago

We would have to check, but the previous annotation wasn't actually used, and I'm not sure about the new annotation. I saw sometimes ago that these patches were necessary:

Since ExperimentalCriticalPodAnnotation is false by default as per https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/.

MaximilianMeister commented 5 years ago

We would have to check, but the previous annotation wasn't actually used, and I'm not sure about the new annotation. I saw sometimes ago that these patches were necessary:

681

682

Since ExperimentalCriticalPodAnnotation is false by default as per https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/.

good catch. this seems very likely. i think the best for now is to get those PR's merged

MaximilianMeister commented 5 years ago

now that we are on 1.13 we need to consider this

spiarh commented 5 years ago

@MaximilianMeister kube-flannel pods would also require this annotation

MaximilianMeister commented 5 years ago

kube-flannel pods would also require this annotation

@lcavajani thanks for the hint. updated