SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

caasp_filters: properly parse IP addresses #717

Closed mssola closed 5 years ago

mssola commented 5 years ago

As it appears, for Python 2 Salt is using a custom module for providing the ipaddress from Python 3. This implementation turned out to have bugs (e.g. accepting something70.domain.net as a valid IPv4 record). I've re-implemented the is_ip* functions so they are using socket.inet_pton instead, which should suffice in our use case.

bsc#1123291

Signed-off-by: Miquel Sabaté Solà msabate@suse.com