search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

replace assert with try/raise #745

Closed MalloZup closed 5 years ago

MalloZup commented 5 years ago

Is better to use a try/raise mechanism then a generic ex without a failure reason. This can be usefull for tracing down debug issues

inercia commented 5 years ago

Take into account that assertions are not used with the same intention as try: except: blocks.

While try: except: blocks are used for catching errors that can be treated, silenced, or wrapped in better errors, assertions are intended to be used when developing as a firewall that stops the execution of a program before things go utterly wrong and the bug becomes too difficult to be found.

Assertions make a good team with unit tests, where we can check things but we want to quickly stop execution when something looks suspicious. That is the reason why assertions are just disabled when the Python interpreter is run with optimizations (python -O).

inercia commented 5 years ago

I would close this PR. The intention of that assertion is to be used at development, expressing a you can be sure the file exists at this point, like an invariant.