Closed inercia closed 5 years ago
looks good to me, however i'm not honestly a fun of todo in Code and i think we could maybe try thing to fix it. Or we open an isssue in github
Well, I personally do not see anything bad in TODOs. It flags something that can be fixed in the future but it is not urgent, so maybe in a second refinement of the code we could investigate about adding some other syncs.
Anoter thing i was looking for , was about
{%- set _ = salt.caasp_orch.sync_all() %}
theset
method, i find it really cool your approach, but i wask asking me if it is the only method used for salt for doing such things? ( it is more open question)
I haven't found any other way of doing this. Function calls in Jinja templates must return a value that is going tot be printed, and we don't want to print anything, so I think this is the only solution...
mine.get
calls by the more compactget_with_expr
function.bsc#1124784