SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

Synchronize everything before starting an orchestration. #746

Closed inercia closed 5 years ago

inercia commented 5 years ago

bsc#1124784

inercia commented 5 years ago

looks good to me, however i'm not honestly a fun of todo in Code and i think we could maybe try thing to fix it. Or we open an isssue in github

Well, I personally do not see anything bad in TODOs. It flags something that can be fixed in the future but it is not urgent, so maybe in a second refinement of the code we could investigate about adding some other syncs.

Anoter thing i was looking for , was about {%- set _ = salt.caasp_orch.sync_all() %} the set method, i find it really cool your approach, but i wask asking me if it is the only method used for salt for doing such things? ( it is more open question)

I haven't found any other way of doing this. Function calls in Jinja templates must return a value that is going tot be printed, and we don't want to print anything, so I think this is the only solution...