search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

update haproxy tag to the version for caasp4 #747

Closed jordimassaguerpla closed 5 years ago

jordimassaguerpla commented 5 years ago

Signed-off-by: Jordi Massaguer Pla jmassaguerpla@suse.de

jordimassaguerpla commented 5 years ago

This needs to go together with https://github.com/kubic-project/caasp-container-manifests/pull/221

jordimassaguerpla commented 5 years ago

@MaximilianMeister : will it be ok for you that we merge both Requests? I don't think tests can pass separately...

MalloZup commented 5 years ago

there is a an hackish way to test 2 prs (from 2 diff repos) before merging. you can do this in the repo jenkins-library with a PR and from there specify your salt and other repos, i think we could do it before merging.

jordimassaguerpla commented 5 years ago

@MalloZup that sounds great! Could you do that for me? Unfortunately I am not familiar enough with the CI setup to do this hack ... I would really appreciate since this is the last thing needed for the next release.

MalloZup commented 5 years ago

@jordimassaguerpla this should work here https://github.com/SUSE/caasp-jenkins-library/pull/276

MalloZup commented 5 years ago

@MaximilianMeister i have done the Pipeline for the 2 prs, is running now: http://jenkins.caasp.suse.net/blue/organizations/jenkins/jenkins-library.integration/detail/PR-276/5/pipeline

if green we can merge. I have created follow-up issue

hwoarang commented 5 years ago

@MaximilianMeister i have done the Pipeline for the 2 prs, is running now: http://jenkins.caasp.suse.net/blue/organizations/jenkins/jenkins-library.integration/detail/PR-276/5/pipeline

if green we can merge. I have created follow-up issue

@MalloZup where is the follow up issue?

MalloZup commented 5 years ago

it is in between comments @hwoarang :gear: it is here: https://github.com/kubic-project/salt/issues/748

MaximilianMeister commented 5 years ago

I cherry-picked into https://github.com/kubic-project/salt/pull/750