search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

[bsc#1127930] Fix cilium ds toleration and rbac clusterrole #757

Closed nirmoy closed 5 years ago

nirmoy commented 5 years ago

@inercia @jordimassaguerpla please review

MalloZup commented 5 years ago

feel free to merge after green

thx for all reviewers, keep dancing :man_dancing:

vadorovsky commented 5 years ago

velum_cilium_green cilium_sw_demo

:)

jordimassaguerpla commented 5 years ago

@MalloZup CI fails but cilium does not go through any tests, so I think the failures are unrelated. Can we merge?

nirmoy commented 5 years ago

feel free to merge after green

thx for all reviewers, keep dancing

It's tricky to make CI green :)

MalloZup commented 5 years ago

the test Red i never seen them failing we might need to check the root cause

MalloZup commented 5 years ago

failure is here .http://jenkins.caasp.suse.net/blue/organizations/jenkins/salt.integration/detail/PR-757/7/pipeline investagate there

i have retriggered the test/.

Honestly i never seen the tox tests failing. It is worth to investiage imho

nirmoy commented 5 years ago

@MalloZup the problem is if you rerun the CI the failure is different, to make CI green all I have to do is finger cross and rerun till it gets green :)

MalloZup commented 5 years ago

failure is on orch.update. it is a know product bug race condition. retriggering. iF it is green we can merge

nirmoy commented 5 years ago

@MalloZup @jordimassaguerpla @mrostecki Green :)