search

SUSE / caasp-salt

A collection of salt states used to provision a kubernetes cluster
Apache License 2.0
64 stars 29 forks source link

update.sls: start transactional-update timer #773

Closed jvanz closed 4 years ago

jvanz commented 4 years ago

In the update process we disable the transactional update timer and re enabled it after update the machine. However, just re enable it is not enough. We need to start the timer. Otherwise, the update service will not run and consequently no updates is installed. This commit adds in the update.sls a step to start the timer after re enabling it.

bsc#1141675

Signed-off-by: José Guilherme Vanz jguilhermevanz@suse.com

jvanz commented 4 years ago

There is an identical state already, can we use that and fix the logic check? https://github.com/kubic-project/salt/blob/master/salt/orch/update.sls#L521

Yes, I've submitted the wrong patch. I've updated the branch with other patch. In this patch I did not add a step. I just changed the salt state to service.running instead of service.enable.

stefsuse commented 4 years ago

FYI @ release-eng for backport. @ QA please take a look and determine if we need another test, thanks.

jvanz commented 4 years ago

It seems the tests are not running because I'm not a kubic project member. Can you allow the tests to run? I'm sure if I can do that, even if I'm SUSE employee. =P

jvanz commented 4 years ago

I don't know why the required test is failing. Seems to be not related to my changes. Am I wrong?

stefsuse commented 4 years ago

The failure looks like an issue connecting to the registry. Added some extra reviewers who might know more.

jordimassaguerpla commented 4 years ago

I don't know about the CI, sorry. Maybe @pablochacin or @tdaines42 can help here.. can you?

jordimassaguerpla commented 4 years ago

The CI is broken atm. Let's go ahead and merge this and we will do manual testing with the Maintenance Update.