search

SUSE / caasp-services

Layered Services on the SUSE Container-as-a-Service Platform
Apache License 2.0
25 stars 30 forks source link

Helm deployment instructions are incorrect #46

Closed ne0777 closed 6 years ago

ne0777 commented 6 years ago

Portus is NOT located on the incubator repository at this time. And yet the instructions on the deploy instructions reference it more than once.

https://github.com/kubic-project/caasp-services/tree/master/contrib/helm-charts/portus

https://kubernetes-charts-incubator.storage.googleapis.com/

stefsuse commented 6 years ago

So it isn't. This is left over from a PR from a long time ago that never got merged into incubator iirc. We'll remove the mention in a future change, thanks.

ne0777 commented 6 years ago

Thanks, I saw the PR and read through all of it... seems like just some last hurdles (tests) to pass to get it bumped into stable (per: https://github.com/kubernetes/charts/pull/2766).

Don't know how stale that is? Is it still worth fighting the good fight on?

stefsuse commented 6 years ago

Yes that is the one. I was not involved with the project at the time so I can't speak to why it was not merged initially... but I do have to admit, that PR been open for quite a while! It looks like the most recent issue is just from requirements.lock?

With that said the 2 charts have diverged quite a bit, and the incubator PR chart is still based on openSUSE/portus:2.2 though 2.3 has had some significant updates.