SUSE / cap

Apache License 2.0
2 stars 1 forks source link

Cleanup catapult vars and make calls in cap-ci/ #25

Closed viccuad closed 4 years ago

viccuad commented 4 years ago

This PR:

viccuad commented 4 years ago

Thanks! We can postpone this if it's going to create conflicts; the only functionality change is taking out the default stack setting to cflinuxfs3.

The change from make scf* to make kubecf* is cosmetic, as SCF_OPERATOR=true make scf* is aliased to make kubecf* in catapult directly.

For the rest of scf references, I would separate them in internal to catapult (the name of scf-config-values.yaml and chart folders inside of buildfolder etc) and external, such as all the SCF_* env vars. The first ones can be refactored transparently out of the pipeline. For the latter ones I would prefer to add aliases like KUBECF_* := SCF_* or CF_*, so people don't have breakages and don't need to relearn the UI until a catapult v2.

bikramnehra commented 4 years ago

Thanks! We can postpone this if it's going to create conflicts; the only functionality change is taking out the default stack setting to cflinuxfs3.

The change from make scf* to make kubecf* is cosmetic, as SCF_OPERATOR=true make scf* is aliased to make kubecf* in catapult directly.

For the rest of scf references, I would separate them in internal to catapult (the name of scf-config-values.yaml and chart folders inside of buildfolder etc) and external, such as all the SCF_* env vars. The first ones can be refactored transparently out of the pipeline. For the latter ones I would prefer to add aliases like KUBECF_* := SCF_* or CF_*, so people don't have breakages and don't need to relearn the UI until a catapult v2.

We can discuss this in catapult meeting.

viccuad commented 4 years ago

Closing since https://github.com/SUSE/cap/pull/27 got in.