search

SUSE / cap

Apache License 2.0
2 stars 1 forks source link

Adding GitHub's Super-Linter #38

Closed bikramnehra closed 4 years ago

bikramnehra commented 4 years ago

for details see: https://github.blog/2020-06-18-introducing-github-super-linter-one-linter-to-rule-them-all/ https://github.com/marketplace/actions/super-linter

bikramnehra commented 4 years ago

@viccuad let me know if this makes sense. I can update the PR to get rid of travis.

viccuad commented 4 years ago

This looks cool!

Looking at the linting run on this PR, I see

--------------------------------------------
Gathering user validation information...
- Only validating [new], or [edited] files in code base...
awk: cmd. line:1: Unexpected end of string
awk: cmd. line:1: Unexpected end of string

Which I wonder if it is ok. I personally would lint the full repo every time, and not only the changes (which also protects us from direct commits to master). What do you folks think?

On a related note, I would like to have all the shell code in cap-ci in .sh files, out of yamls, so it can get linted properly (but I suppose that should happen in a different PR).

viccuad commented 4 years ago

Does the linter lint shellscripts? (the output from the job doesn't tell what was linted)