SUSE / connect-ng

Other
9 stars 16 forks source link

zypper.CreateTarball() should check for path existence inside specified root, not locally #231

Closed rtamalin closed 5 months ago

rtamalin commented 5 months ago

While adding tests to validate the fix for PR #229 I was seeing failures related to tar not being passed any paths to include in the tarball.

Digging in to the issue I realised that the problem was related to the fact that the check for the target paths existing was being done in the local file system environment, rather than in the testing root environment that I had setup for the test, and I was running the tests on my Ubuntu system (rather than my Leap system) where /etc/zypp and /etc/products.d don't exist.

Updating the CreateTarball() path existence checking to check for the candidate paths under the specified root, rather than in the local file system fixes this issue.