SUSE / container-suseconnect

Provides access to repositories inside containers using the host entitlements
Apache License 2.0
19 stars 16 forks source link

Added support for on-demand public cloud instances #43

Closed mssola closed 4 years ago

mssola commented 4 years ago

Fixes SUSE/avant-garde#1655

Depends on: https://github.com/SUSE-Enceladus/cloud-regionsrv-client/pull/34

rhafer commented 4 years ago

@flavio I admit this looks a bit scary for the number of commits. But I think each one for it's own isn't too big. If you prefer I can still go through then an try to squash where it makes sense.

flavio commented 4 years ago

I'm fine leaving them like that because they provide more details when looking back at the history of the repo/of a file. I don't like to have 1 gigantic commit.

rhafer commented 4 years ago

Thanks for the review. I'll wait with merging until we have a go for the server side pull request.

rhafer commented 4 years ago

The server side PR was just merged. I am going to merge this one as well. I'll submit a few smaller changes as follow ups. (e.g. Documentation)