search

SUSE / container-suseconnect

Provides access to repositories inside containers using the host entitlements
Apache License 2.0
19 stars 16 forks source link

Documentation for "Building images on non SLE distributions" is wrong in README.md #48

Closed mwilck closed 3 years ago

mwilck commented 3 years ago

The given docker command line doesn't work. Instead of

--build-arg ADDITIONAL_MODULES=PackageHub

it should be

--build-arg ADDITIONAL_MODULES=sle-module-development-tools

In general, the syntax of the ADDITIONAL_MODULES parameter should be explained better.

saschagrunert commented 3 years ago

Hey @mwilck, thank you for opening the issue! :pray: Do you mind proposing a PR with the mentioned improvements?

mwilck commented 3 years ago

I can do this part, but not the documentation of ADDITIONAL_MODULES.

Suggestion for further improvement: add a default value for ADDITIONAL_MODULES in the Dockerfile.

mwilck commented 3 years ago

We really need a list of possible values for ADDITIONAL_MODULES somewhere.

rhafer commented 3 years ago

@mwilck container-suseconnect --list-modules is supposed to give that list I think. Or SUSEConnect --list-extensions (this one works of course only on a SLE host).

The list of possible modules depends on the Base Container (and maybe even on the used credentials) so there is not single list of truth that we can add to the documentation.

mwilck commented 3 years ago

Ok, I was unaware that container-userconnect was an executable I could call. Thanks.

I still think a list of modules with their abbreviations should be documented somewhere, at least for the official SUSE modules. That's not up to you of course.

Also, it's not documented how to specify multiple modules (it seems to work by joining them with a comma, but the user needs to guess that).

rhafer commented 3 years ago

Ok, I was unaware that container-userconnect was an executable I could call. Thanks.

You're welcome. (It's also documented in the README :-) )

I still think a list of modules with their abbreviations should be documented somewhere, at least for the official SUSE modules.

It might be possible to find that in the SCC. I don't know.

Also, it's not documented how to specify multiple modules (it seems to work by joining them with a comma, but the user needs to guess that).

Yeah, I guess that makes sence.