search

SUSE / container-suseconnect

Provides access to repositories inside containers using the host entitlements
Apache License 2.0
19 stars 16 forks source link

Improve documentation when building with podman on non-SLE host #61

Closed fcrozat closed 2 years ago

fcrozat commented 2 years ago

Add alternative documentation for building with podman on non-SLES host

lagartoflojo commented 2 years ago

Title: "building with podman on SLE host" Summary: "building with podman on non-SLES host"

I think the description needs to be corrected =)

fcrozat commented 2 years ago

Title: "building with podman on SLE host" Summary: "building with podman on non-SLES host"

I think the description needs to be corrected =)

fixed ;)

lagartoflojo commented 2 years ago

But I think you meant to say "building with podman on SLES host," no? AFAIU the description was wrong, not the title. Because non-SLES hosts don't have the SUSEConnect config nor the zypper credential files.

fcrozat commented 2 years ago

But I think you meant to say "building with podman on SLES host," no? AFAIU the description was wrong, not the title. Because non-SLES hosts don't have the SUSEConnect config nor the zypper credential files.

No, the podman changes are already part of SLES podman. The changes descripted in this PR are needed on non-SLES host, as an addition to the section "Building images on non SLES distribution" which is docker focused.

lagartoflojo commented 2 years ago

Ahh got it, thanks. You might also need to update the commit message then =)

fcrozat commented 2 years ago

Ahh got it, thanks. You might also need to update the commit message then =)

Oh my... Fixed ;)