search

SUSE / ha-sap-terraform-deployments

Automated SAP/HA Deployments in Public/Private Clouds
GNU General Public License v3.0
122 stars 88 forks source link

azure: add initial ANF (Azure Netapp Files) shared storage support #733

Closed yeoldegrove closed 3 years ago

yeoldegrove commented 3 years ago

This is the initial ANF (Azure Netapp Files) shared storage support for azure. ANF implementation is based on https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/sap-hana-scale-out-standby-netapp-files-suse#mount-the-azure-netapp-files-volumes

HANA and S4/HANA deployments are tested with this code.

More documentation can be found in #734 which adds the HANA scale-out part. This PR is a prerequisite to deploy HANA scale-out on azure.

nick-wang commented 3 years ago

Are the commits of this pull request also included in https://github.com/SUSE/ha-sap-terraform-deployments/pull/734? If so, could focus on the later one only.

yeoldegrove commented 3 years ago

Are the commits of this pull request also included in #734? If so, could focus on the later one only.

Yes they are...as this shared storage implementation is a prerequisite to enable scale-out in #734. The ANF feature should be merged separately though.

nick-wang commented 3 years ago

Yes they are...as this shared storage implementation is a prerequisite to enable scale-out in #734. The ANF feature should be merged separately though.

Well, it is slightly wired we have everything(discussion/code) in #734 but merge this pull request first. Even if we do so, the scale-out pull request (#734) need rebase on this. Then the code belong here won't be shown in #734 anymore.

yeoldegrove commented 3 years ago

@arbulu89 please review again

stefanotorresi commented 3 years ago

@yeoldegrove I didn't quite understand one thing: you say this implementation depends on the scale-out, and there are references to that in the code, but that's not merged in yet. What gives?

yeoldegrove commented 3 years ago

@stefanotorresi It is the other way around... scale-out depends on this ANF code, as shared storage is needed for scale-out. Nevertheless this ANF implementation is based on the "Azure HANA scale-out reference implementation" (this is what the link is supposed to say).

The plan is to merge this PR first and after that the scale-out PR #734. I am just testing out a few last scenarios.

stefanotorresi commented 3 years ago

Thank you for the clarification!