search

SUSE / ha-sap-terraform-deployments

Automated SAP/HA Deployments in Public/Private Clouds
GNU General Public License v3.0
122 stars 88 forks source link

powervs: set provider to 1.33.0 #775

Closed mfriesenegger closed 2 years ago

mfriesenegger commented 2 years ago

ibm terraform provider v1.33.1 deprecates pi_network_id replacing with pi_network which introduces new capabilities. Setting the provider to 1.33.0 keeps the Argument is deprecated warning from happening while pi_network_id is replaced.

mfriesenegger commented 2 years ago

Please use ~> to set a sensitive lower and upper boundary to the provider version. Some more details are found here: https://www.terraform.io/docs/language/expressions/version-constraints.html#terraform-core-and-provider-versions

If I use ~> 1.33.0 then the documentation suggests that 1.33.1 will be installed. 1.33.1 generates the deprecation warning which I want to avoid. This change is temporary until I have had time to update the terraform with the new pi_network option and capabilities.

yeoldegrove commented 2 years ago

@mfriesenegger Than just add a short comment why you hard pin this version and we're good to go.