SUSE / ha-sap-terraform-deployments

Automated SAP/HA Deployments in Public/Private Clouds
GNU General Public License v3.0
122 stars 88 forks source link

Master branch for GCP - terraform plan show error #828

Closed busetde closed 2 years ago

busetde commented 2 years ago

Hi @yeoldegrove,

Tried the updated master branch for GCP but got error like below while execute terraform plan as below. Could you kindly advise what's wrong, as I've tried the previous develop branch it's not shows error when run terraform plan?

image

Regards - Budi

yeoldegrove commented 2 years ago

@busetde I could not reproduce this error with a cleanly cloned master branch and a cp terraform.tfvars.example terraform.tfvars. Are you sure you are using the latest master commit?

busetde commented 2 years ago

Hi @yeoldegrove,

I've just done the below -Clone from master branch git clone -b master https://github.com/SUSE/ha-sap-terraform-deployments.git -Copy previous working terraform.tfvars -Run terraform plan the same error like below: image

-Run terraform plan from the previously working develop branch, there's no error like below: image

Could you please kindly advise on what I need to check?

Appreciated - Budi

yeoldegrove commented 2 years ago

@busetde Could you share a redacted terraform.tfvars?

busetde commented 2 years ago

@yeoldegrove

Please find the redacted terraform.tfvars

Regards - Budi

yeoldegrove commented 2 years ago

Found the issue... When updating the GCP code to the latest terraform provider, we forgot to test the deployment without a bastion and hence the firewall resources are missing source_ranges = ["0.0.0.0/0"].

830 fixes this.

busetde commented 2 years ago

@yeoldegrove

Could you please kindly advise if I can test this from the master branch?

Regards - Budi

yeoldegrove commented 2 years ago

@busetde It is available in develop already. I plan to release 8.0.1/master today/tomorrow.

yeoldegrove commented 2 years ago

@busetde https://github.com/SUSE/ha-sap-terraform-deployments/releases/tag/8.0.1 hast just released, including fixes for this issue