search

SUSE / hackweek

SUSE Hack Week tools and data
https://hackweek.opensuse.org/
MIT License
63 stars 53 forks source link

Update rubocop-rspec 2.31.0 → 3.0.1 (major) #1555

Closed depfu[bot] closed 3 weeks ago

depfu[bot] commented 3 weeks ago

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.31.0 → 3.0.1) · Repo · Changelog

Release Notes

3.0.1

  • Bump RuboCop requirement to +1.61. (@ydah)

3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@ydah)
  • Remove RSpec/FilePath cop. (@ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ rubocop-capybara (removed)

🗑️ rubocop-factory_bot (removed)

🗑️ rubocop-rspec_rails (removed)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)