search

SUSE / hanadb_exporter

Prometheus exporter for SAP HANA databases
Apache License 2.0
46 stars 27 forks source link

add Grafana dashboard #71

Closed stefanotorresi closed 4 years ago

stefanotorresi commented 4 years ago

This PR moves the Grafana dashboard inside the exporter repo, while also updating its UX.

Here is a screenshot demonstrating the changes: screenshot-details

And a live demo here: http://10.162.30.253:3000/d/EcC4JDFWz2/sap-hana-details

The OBS packaging was deliberately left out and not implemented in the existing Travis CI config: this will be addressed in a follow-up PR by switching to GitHub actions, which allows for multiple CI pipelines in the same repo.

stefanotorresi commented 4 years ago

About the dashboards, I like the new styling. What I don't really like is how grafana creates the table rows. For example, in the alerts table, it's quite difficult to split between the different rows, making quite uncomfortable to read them. It's a minor detail though. Is it possible to change the background color of the subsequent rows? To make it more different between them.

Yeah, I see your point, but sadly we can't change anything about how the table rows are displayed.

Besides that, I don't really understand the initial alerts chart (the pie chart). What's the meaning of this green part?

Hmm that was actually a bug: it's a threshold marker; the threshold was incorrectly set to 1, while it had to be 0 (i.e. anything more than 0 will appear as red). Since the only green value is 0, I will remove the marker entirely.