search

SUSE / hanadb_exporter

Prometheus exporter for SAP HANA databases
Apache License 2.0
46 stars 27 forks source link

Fix filesystem details panel #74

Closed stefanotorresi closed 4 years ago

stefanotorresi commented 4 years ago

Minor fixes to the file system panel, which was not correctly reporting the percentage of disk used.

stefanotorresi commented 4 years ago

ok. are the PR for devel dash sent to exporter?

hmm I'm not sure what are you asking; if mean what happens when PRs get merged, they update just the dashboard devel package if dashboard files were changed.

MalloZup commented 4 years ago

@stefanotorresi ignore the comment I was thinking it was the ha-deployment repo. :grin:

stefanotorresi commented 4 years ago

I removed the ROOTKEY_BACKUP key for now, because by default we don't even backup root keys, and also I don't think these will ever use so much disk to be something to keep an eye on.

And I am also thinking if we add the hana backup type->size metrics in future, it would be nice

Hmm, I'm not quite clear; doesn't the usage_type label on the existing metric do this already?