Closed elturkym closed 2 years ago
Hi @arbulu89,
Thanks,
Mohamed
I have moved the secrets manager changes to this new pull request https://github.com/SUSE/hanadb_exporter/pull/97 as recommended.
I will keep this PR for scale-outs handling
Hi @arbulu89,
I have updated this PR with the new modification for scale-out handling, I used the same PR to keep the conversation history.
This approach depends on starting the export with master host:
db.start
again with new master host. Unit-test and documentation are remaining, but I will add them while addressing any comments from you about these changes.
Hi @elturkym , I'm back at work. I will have a look on this on these 1st days of the week and get you back with my feedback.
Hi @elturkym , Many things commented below. I think we need to rethink many things.
- I think many parts of the code must be replaced to the database manager, which should handle scale out connections
I have replied back to all the comments and we can discuss offline
- We should most probably return some metric for standby nodes, otherwise they just don't do anything, and I don't know why we should collect their information
it returns python metrics python_info{implementation="CPython",major="3",minor="8",patchlevel="4",version="3.8.4"} 1.0
as mentioned in the description
- I don't really like the idea to connect to the master node from all the active nodes, if this is the case, don't they return all the same values? Is this something logical? (or am I missing something?). If the data is duplicated, maybe we should just return a metric saying that their role and only return data from the master (the first thing that came to my mind)
I am expecting to have only active master node at the time, the data should be duplicated. currently workers will return some python metrics as mentioned in the description, let it me if you think we should add specific metric to tell it is standby node I am not sure what is the cost of that.
@arbulu89 and @stefanotorresi Is there any update on where we are with this? We had planned to ship this and https://github.com/SUSE/hanadb_exporter/pull/97 , see https://jira.suse.com/browse/SLE-20632 .
Hi All,
I am going to close this PR, since the priorities have changed in our end, I won't be able to continue working in this feature during this year.
Thanks so much for helping me in this PR and https://github.com/SUSE/hanadb_exporter/pull/97 as well
Looking forward to working with you again.
Best regards,
Mohamed Elturky
SCALE-OUT/FAILOVER
scale_out_mode
a boolean flag to enable this feature, it is false by default.Examples:
curl response: