search

SUSE / libpulp

libpulp enables live patching in user space applications.
GNU Lesser General Public License v2.1
55 stars 11 forks source link

`ulp patches -p PID` crashes, if the PID does not exist #186

Closed scmschmidt closed 1 year ago

scmschmidt commented 1 year ago

Tested with v0.2.10.

# ./ulp patches -p 65271
ulp: Failed to parse data for live-patchable process 65271: Operation not permitted
ulp: patching state address is NULL.
Segmentation fault (core dumped)
giulianobelinassi commented 1 year ago

Confirmed.

scmschmidt commented 1 year ago

Thanks. Now I get:

# ./ulp patches -p 9999
ulp: Failed to parse data for live-patchable process 9999: Operation not permitted

I would have expected the same error message like with trigger:

# ./ulp trigger -p 9999 '/usr/lib64/openssl-1_1-livepatches/0.1/lib*.so'
ulp: error gathering target process information.

Here it is clear, that something with the process is causing it. Is there a reason you choose a different message?

giulianobelinassi commented 1 year ago

Actually, no. It is just a different part of the tool that is detecting the issue. I will standardize this.