search

SUSE / libpulp

libpulp enables live patching in user space applications.
GNU Lesser General Public License v2.1
55 stars 11 forks source link

`-p PID` does not work with `trigger` #187

Closed scmschmidt closed 1 year ago

scmschmidt commented 1 year ago

Tested with v0.2.10.

# ./ulp trigger -p 7918 '/usr/lib64/openssl-1_1-livepatches/0.1/lib*.so'
ulp: error opening /usr/lib64/openssl-1_1-livepatches/0.1/lib*.so: No such file or directory
error: could not apply /usr/lib64/openssl-1_1-livepatches/0.1/lib*.so to sshd (pid 7918): No metadata in .so

The same command without -p PID works:

# ./ulp trigger '/usr/lib64/openssl-1_1-livepatches/0.1/lib*.so'
sshd (pid: 7838): SKIPPED Patch already applied
sshd (pid: 7918): SKIPPED Patch already applied
ulp: Processes patched: 0, Skipped: 25, Failed: 0.

The same happened if a live patch could loaded into sshd successfully.

giulianobelinassi commented 1 year ago

If you pass -p PID on trigger it disables batch processing mode. But that can be supported as well.

scmschmidt commented 1 year ago

I assumed that -p PID would work from the output of --help:

 patches, check & trigger commands only:
      --disable-threading    Do not launch additional threads
  -p, --process=process      Target process name, wildcard, or PID