search

SUSE / lrbd

GNU Lesser General Public License v2.1
24 stars 19 forks source link

"make tests" fails on master #6

Closed ktdreyer closed 8 years ago

ktdreyer commented 8 years ago

Some of the changes in commit f5407a726f3d9cab6f019ad40b5638dac18158a7 caused make tests to no longer work properly.

ktdreyer commented 8 years ago

cc @mikechristie since he's been looking at this codebase recently

swiftgist commented 8 years ago

I have a few other requests and correcting unit tests now. Are you adding this to your automated builds?

ktdreyer commented 8 years ago

We do run make tests as part of the lrbd RPM build process in Fedora (although it's not 100% automated to the point of running on every upstream Git commit.)

The reason I noticed this issue was that Mike and I were working on packaging the tip of master, so that we could use the very latest bits.

swiftgist commented 8 years ago

On Tuesday, March 15, 2016 05:58:57 AM Ken Dreyer wrote:

We do run make tests as part of the lrbd RPM build process in Fedora (although it's not 100% automated to the point of running on every upstream Git commit.)

The reason I noticed this issue was that Mike and I were working on packaging the tip of master, so that we could use the very latest bits.

You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/SUSE/lrbd/issues/6#issuecomment-196806312 With yesterday's change, is make tests passing for you?

swiftgist commented 8 years ago

Tests are working. Closing.