search

SUSE / machinery

A systems management toolkit for Linux
GNU General Public License v3.0
159 stars 32 forks source link

Encapsulate Machinery classes in the Machinery module namespace #2171

Closed bear454 closed 7 years ago

bear454 commented 8 years ago

Resolves https://github.com/SUSE/machinery/issues/2170 by encapsulating all Machinery classes in the Machinery:: module.

Bonus: UI-specific code is namespaced in Machinery::Ui::.

bear454 commented 8 years ago

Rubocop reports 2092 offenses and @houndci-bot won't give me a complete list of its complaints... just adds more comments after each fix. How am I supposed to get the style in shape?

thardeck commented 8 years ago

@bear454 Thx for your pr. You could use the rubocop-git extension on your changes before committing them.

bear454 commented 8 years ago

@thardeck this is as far as I'm willing to go, wrt to style guide. Making any more changes would be too intrusive on the codebase, considering the sum total of change here is to prefix with the Machinery:: module name, and in a few cases, some indenting.

thardeck commented 7 years ago

Superseded by #2202