SUSE / rmt

RPM repository mirroring tool and registration proxy for SUSE Customer Center.
Other
37 stars 46 forks source link

Do not add service credential url paramter if not necessary #1076

Closed felixsch closed 5 months ago

felixsch commented 5 months ago

In normal RMT environments, zypper services do not need a ?credentials URL parameter since the repository path is not authenticated. So do not add it and allow yum to work with RMT for SLL7

part of: https://trello.com/c/BSMxlGDN/3166-help-liberty-team-get-suseconnect-working-on-liberty-7

How to review this pull request:

$ cd <rmt>
$ git checkout no-credentials-in-service-url
$ rails server

# another terminal
$ docker run --rm -it --network=host registry.suse.com/suse/sle15:15.4
> zypper in -y suseconnect-ng curl tidy
> SUSEConnect --url http://localhost:4224
> cat /etc/zypp/credentials.d/SCCcredentials
> curl -u <username:password> http://localhost:4224/services/2292 | tidy -xml -iq 
# expect: There is no `?credentials=XXX` in the repo.url

If you have any questions, please do not hesitate to reach out to me! :rocket:

Thank you!

felixsch commented 5 months ago

@jesusbv is looking into if it is possible to remove ?credentials= from the zypper_auth engine. Thank you

ngetahun commented 5 months ago

Pubcloud tests seem to be broken

jesusbv commented 5 months ago

@jesusbv is looking into if it is possible to remove ?credentials= from the zypper_auth engine. Thank you

@felixsch I have checekd and we do need the credentials

suse-tests-pass commented 5 months ago

Well Done! Your tests are still passing. https://ci.suse.de/job/scc-RMT-integration-tests/355609/console If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged 3b28555b305f7eb043a9070a74b32a899c834b1f into 024478b7c8a9b7c45d617377f2c472917220d603)