Adding Uptime tracking capability

chajain commented 4 months ago

Description

Uptime data is included in the data sent to SCC via RMT https://jira.suse.com/browse/CSE-504

Fixes # (issue)

Change Type

Please select the correct option.

[ ] Bug Fix (a non-breaking change which fixes an issue)
[X] New Feature (a non-breaking change which adds new functionality)
[ ] Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

[X] I have verified that my code follows RMT's coding standards with rubocop.
[ ] I have reviewed my own code and believe that it's ready for an external review.
[ ] I have provided comments for any hard-to-understand code.
[ ] I have documented the MANUAL.md file with any changes to the user experience.
[X] RMT's test coverage remains at 100%.
[ ] If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes. How to test this PR

On the client system clone https://github.com/SUSE/connect-ng/pull/202 ( this PR has the connect-ng changes for uptime tracking feature ) Also clone https://github.com/SUSE/uptime-tracker On the RMT system, clone this code Execute rails db:migrate to create the system_uptimes table Start the server bin/rails server -b 0.0.0.0 Register the system on client system using command suseconnect --url , it should populate the system_uptimes table with the entries from /etc/zypp/suse-uptime.logs on client system

rjschwei commented 3 months ago

AFIK version bumps are handled independently, i.e. lib/rmt.rb and the spec file changes should not be part of the PR. The Public Cloud team expects support for Debian repositories as the primary feature of 2.16, not sure is that is merged yet.

digitaltom commented 3 months ago

AFIK version bumps are handled independently, i.e. lib/rmt.rb and the spec file changes should not be part of the PR. The Public Cloud team expects support for Debian repositories as the primary feature of 2.16, not sure is that is merged yet.

Yes, please just add a note about the changes to the changelog, we'll include it into the next release and take care about the versioning.

yarunachalam commented 2 months ago

AFIK version bumps are handled independently, i.e. lib/rmt.rb and the spec file changes should not be part of the PR. The Public Cloud team expects support for Debian repositories as the primary feature of 2.16, not sure is that is merged yet.

Yes, please just add a note about the changes to the changelog, we'll include it into the next release and take care about the versioning.

Do I need to remove the spec file from this PR ?

digitaltom commented 2 months ago

Do I need to remove the spec file from this PR ?

I think you have changes in the .spec file that you need to keep regarding the timers. But you don't need to change the version number. Just add a description of the change to the changelog, and the team will take care about the versioning + release.

chajain commented 2 months ago

Performed the end to end testing along with SCC latest PR https://github.com/SUSE/happy-customer/pull/7339 and connect-ng PR https://github.com/SUSE/connect-ng/pull/210 and verified following scenarios

Creation of system_uptime table with db:migrate
Populating the system_uptime table when the keepalive heartbeat is sent from client
rmt-cli systems scc-sync syncs the system_uptime tables on SCC from RMT

SUSE / rmt