SUSE / rmt

RPM repository mirroring tool and registration proxy for SUSE Customer Center.
Other
37 stars 46 forks source link

702 summary of mirroring #1116

Closed Adnilson closed 2 months ago

Adnilson commented 3 months ago

Description

These are the changes I did on my technical interview to improve the summary of the mirroring process.

Fixes #702

Change Type

Please select the correct option.

Checklist

Please check off each item if the requirement is met.

Other Notes

Maybe we can update some rubocop rules

Regarding spec/lib/rmt/cli/mirror_spec.rb:

RSpec/ClassLength in this case there 3 more lines than the limit which is 177. Is there a reason for this number? I prefer deep modules (with a simple interface) than shallow modules (with a complex interface) as I learned from: A Philosophy of Software Design by John Ousterhout.

Adnilson commented 2 months ago

This PR will be closed in favor of https://github.com/SUSE/rmt/pull/1122

After merging there were many conflicts to solve, specially on the tests.