Handle the empty credentials from the container runtime tools on the client - Githubissues

SUSE / rmt

RPM repository mirroring tool and registration proxy for SUSE Customer Center.

Other

38 stars 45 forks source link

Handle the empty credentials from the container runtime tools on the client #1208

Closed jesusbv closed 3 months ago

jesusbv commented 3 months ago

Description

When container runtime tools on the client do not send the proper credentials or an exception happens during the catalog search, handle the exception

How to test

Put wrong credentials on /etc/containers/config.json and run podman search foo and autentication required message is shown

ec2-user@ip-172-31-21-235:~> sudo /usr/bin/cloudguestregistryauth 
Credentials refreshed
ec2-user@ip-172-31-21-235:~> podman search foo
ERRO[0000] error getting search results from v2 endpoint "registry-ec2.susecloud.net": authentication required 
Error: 1 error occurred:
    * couldn't search registry "registry-ec2.susecloud.net": authentication required

ec2-user@ip-172-31-21-235:~>

Change Type

Please select the correct option.

[ ] Bug Fix (a non-breaking change which fixes an issue)
[X] New Feature (a non-breaking change which adds new functionality)
[ ] Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

[X] I have reviewed my own code and believe that it's ready for an external review.
[X] I have provided comments for any hard-to-understand code.
[ ] I have documented the MANUAL.md file with any changes to the user experience.
[ ] If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines and get in touch with the author to get a shared understanding of the change.