Add header to SCC endpoint

jesusbv commented 3 months ago

Description

Add test to check the header is sent

How to test

Change Type

Please select the correct option.

[X] Bug Fix (a non-breaking change which fixes an issue)
[ ] New Feature (a non-breaking change which adds new functionality)
[ ] Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

[X] I have reviewed my own code and believe that it's ready for an external review.
[X] I have provided comments for any hard-to-understand code.
[ ] I have documented the MANUAL.md file with any changes to the user experience.
[ ] If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines and get in touch with the author to get a shared understanding of the change.

rjschwei commented 3 months ago

@digitaltom @felixsch if this looks good to you please merge and create a RMT 2.19 package for us to test.

jesusbv commented 3 months ago

@digitaltom @felixsch if this looks good to you please merge and create a RMT 2.19 package for us to test.

I understand the testing package should include #1204 (hopefully, once merged) as well

rjschwei commented 3 months ago

I cannot test run this, but code-wise looks ok now. Please also check how often that gets called and the performance of it, because the inline call to SCC can be expensive. Didn't we have a cache for this?

No there is no cache yet for checking if a system is registered and valid with SCC. That is a follow on project we can start once 2.19 is out.

SUSE / rmt