SUSE / rookcheck

Apache License 2.0
4 stars 11 forks source link

lib/hardware: Add openstacksdk base OpenStack hardware provider #125

Closed toabctl closed 4 years ago

toabctl commented 4 years ago

Add another hardware provider that is based on the official OpenStack SDK. That is an alternative to the available apache-libcloud provider. The new provider can be used by setting ROOKCHECK_HARDWARE_PROVIDER=OPENSTACKSDK. There are a couple of advantages over apache-libcloud:

Given that we have anyway another abstraction layer on top of apache-libcloud (for the libvirt provider), there is no real need to use the apache-libcloud abstraction.

Signed-off-by: Thomas Bechtold tbechtold@suse.com

jhesketh commented 4 years ago

I hate that we're having to write and maintain this layer of abstraction. This is something that libcloud was meant to give us but obviously it's not as good a fit as we had hoped.

I agree there are advantages to using the openstacksdk. I don't think we should maintain 2 drivers though, so we should drop the libcloud one if this is the direction we are going to head.

It would be interesting to look at writing an aws or gcp driver to see if we would get any reuse out of libcloud. If so, we should consider improving libcloud to support what we need for openstack.

toabctl commented 4 years ago

This passed a full test_basics.py test run. Ready for merging imo.

toabctl commented 4 years ago

Also discussed with Josh & we agreed to merge this