search

SUSE / rookcheck

Apache License 2.0
4 stars 11 forks source link

tests_basic: Download direct-mount.yaml if not available #180

Closed toabctl closed 4 years ago

toabctl commented 4 years ago

With the SES7 rook rpm package, the direct-mount.yaml rook/ceph example is not available from the rpm package. In that case, download the file from github and use it for testing. Without that, running the basic tests with SES7 fails with:

10:38:44 kubectl apply -f /home/tom/tmp/rookcheck/rook WARNING : \ error: the path "/home/tom/tmp/rookcheck/rookcheck-tom-0ac2/\ rook/ceph/direct-mount.yaml" does not exist

ml8mr commented 4 years ago

I've re-added the direct-mount.yaml to the rook-k8s-yaml package, so this shouldn't be a problem in the future. (I added all the yamls back, so you should be able to use any of them now.)

jhesketh commented 4 years ago

I don't mind if we keep direct-mount (or other examples for that matter) in the rpm. However, if we are going to keep them in the package then we should keep the test as it is to ensure that it is there (and working as expected). If we want to reduce the number of example manifests in the future then we can rework this.

toabctl commented 4 years ago

Closing given that we have the example in the package now. Thanks Mike!