search

SUSE / rookcheck

Apache License 2.0
4 stars 11 forks source link

lib/hardware: Unify and abstract disk_create method #185

Closed toabctl closed 4 years ago

toabctl commented 4 years ago

Create an abstract disk_create() method in the HardwareBase class. That way, it's clear that this method expects an int for the disk capacity in GB. This also fixes the disk deployment for libvirt where test_add_storage() test failed because the rook-discover pod didn't use the newly created disk (due to "Insufficient space (\u003c5GB)"). The extra qcow2 disk that was created for libvirt had a size of 512 byte.

Signed-off-by: Thomas Bechtold tbechtold@suse.com

toabctl commented 4 years ago

passed my local libvirt based CaasP/SES run