Fix upstream build from git

SUSE / rookcheck

Apache License 2.0

4 stars 11 forks source link

Fix upstream build from git #210

Closed brunoleon closed 3 years ago

brunoleon commented 3 years ago

While updatting PR, a chdir() context change was forgottent, leading to a failure when building from GIT. This PR fixes taht by using workspace.execute() and its chdir parameter.

toabctl commented 3 years ago

commit message has several typos and could you add the commit sha there to know which commit broke it?

brunoleon commented 3 years ago

I updated commit msg but it does not update comment above.

brunoleon commented 3 years ago

Failures are not related to the code. If you're happy with it I'll merge this PR. Waiting for your approvals @jhesketh and @toabctl

jhesketh commented 3 years ago

lgtm, thanks :-)