search

SUSE / rookcheck

Apache License 2.0
4 stars 11 forks source link

Remove node #213

Closed toabctl closed 3 years ago

toabctl commented 3 years ago

May be a log message to state the node is being removed could be nice

@brunoleon done

toabctl commented 3 years ago

@jhesketh done

kshtsk commented 3 years ago

I don't think it helps to resolve fundamental issue, because removing node also could have a bug. And it will cause again problem in the next tests. We should just skip the test from the execution if we know it is buggy to ensure the do no harm for the next cases which are reusing the cluster.

jhesketh commented 3 years ago

I don't think it helps to resolve fundamental issue, because removing node also could have a bug. And it will cause again problem in the next tests. We should just skip the test from the execution if we know it is buggy to ensure the do no harm for the next cases which are reusing the cluster.

Maybe we should move this to the end of test_basic so that any bad state it ends up in is irrelevant.

kshtsk commented 3 years ago

I don't think it helps to resolve fundamental issue, because removing node also could have a bug. And it will cause again problem in the next tests. We should just skip the test from the execution if we know it is buggy to ensure the do no harm for the next cases which are reusing the cluster.

Maybe we should move this to the end of test_basic so that any bad state it ends up in is irrelevant.

It is useless and takes extra time, which is bad for integration tests. The faster tests give you result is the best.