search

SUSE / rookcheck

Apache License 2.0
4 stars 11 forks source link

Introduce ANSIBLE_PLAYBOOK_EXTRA_ARGS #215

Open kshtsk opened 3 years ago

kshtsk commented 3 years ago

This change makes it possible to add extra variables for ansible-playbook calls, this is usefull when one want to pass multiple --extra-vars arguments in the native format giving user a choice to use json, name=value pairs or path to yaml/json files.

Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@suse.com

kshtsk commented 3 years ago

The jenkins failure is unrelated to the PR.

jhesketh commented 3 years ago

Does #216 satisfy your needs and supersede this PR?

kshtsk commented 3 years ago

Does #216 satisfy your needs and supersede this PR?

Thanks, I think it covers my needs, however I didn't test it, but it does not supersede current version of this PR, because the latter allow more than just passing --extra-vars.

jhesketh commented 3 years ago

Does #216 satisfy your needs and supersede this PR?

Thanks, I think it covers my needs, however I didn't test it, but it does not supersede current version of this PR, because the latter allow more than just passing --extra-vars.

It is a little confusing, but it is talking about extra arguments to the ansible-playbook command (eg, pass along "--verbose"). Perhaps extra-params would be less confusing?

kshtsk commented 3 years ago

Does #216 satisfy your needs and supersede this PR?

Thanks, I think it covers my needs, however I didn't test it, but it does not supersede current version of this PR, because the latter allow more than just passing --extra-vars.

It is a little confusing, but it is talking about extra arguments to the ansible-playbook command (eg, pass along "--verbose"). Perhaps extra-params would be less confusing?

No, it is not confusing, you are messing vars and args. The variables are internal things in ansible, arguments are the synonym for parameters for a program, same as options.

kshtsk commented 3 years ago

Guys, I don't want to spend your time on this anylonger, if you're not okay with it, I close.