hardware_base: Decouple ANSIBLE_EXTRA_VARS settings

SUSE / rookcheck

Apache License 2.0

4 stars 11 forks source link

hardware_base: Decouple ANSIBLE_EXTRA_VARS settings #216

Closed toabctl closed 3 years ago

toabctl commented 3 years ago

Instead of merging settings.ANSIBLE_EXTRA_VARS with the variable "extra_vars" provided by ansible_run_playbook(), decouple both variables. That way, extra_vars (the method parameter) can be set from the code (eg. the SES rook code) and settings.ANSIBLE_EXTRA_VARS can be set by the user and it can be something independent (eg. a file @foo.yaml).

Signed-off-by: Thomas Bechtold tbechtold@suse.com

jhesketh commented 3 years ago

(we may also need to update the doc/note in the settings).

toabctl commented 3 years ago

@jhesketh I updated the comment in the settings and fixed linting. Should be good now. @kshtsk opinions?

kshtsk commented 3 years ago

Have you tested this @fileparam?

kshtsk commented 3 years ago

Rather than comments I'm fine with that PR.