search

SUSE / salt-shaptools

Salt execution module and state to manage SAP Applications (HANA only at the moment) and SUSE Linux Enterprise High Availability components
Apache License 2.0
14 stars 11 forks source link

Add qdevice #74

Closed aleksei-burlakov closed 3 years ago

aleksei-burlakov commented 3 years ago

@arbulu89 @MalloZup @Simranpal Please have a look. This PR should come together with https://github.com/SUSE/habootstrap-formula/pull/67

aleksei-burlakov commented 3 years ago

@aleksei-burlakov As a side note, I think that we can initialize qdevice in the same command where we start the cluster. This could spare this new command, and we would only need to add the flags in the current code. Just as an additional option.

Please, add the args description in the docstrings too

Done.

aleksei-burlakov commented 3 years ago

thx for pr ! 3 things:

  1. CODE: the code itself need adaption with the existing code. see inline comments
  2. TEST: you need to adapt the tests mocking. see travis failures. ( you can find documentation on mocking on the readme, and looking at existing tests)
  3. PKG: Releases: You need to add a changelog entry to https://github.com/SUSE/salt-shaptools/blob/master/salt-shaptools.changes#L2

and also increment the version number so basically a new pkg will shipped and then the PR you depend on this will also get the new pkgs of this shared lib.

here is where you need to increment: https://github.com/SUSE/salt-shaptools/blob/master/_service#L7

I have refactored the 1. CODE. Now, only left are the 2. TEST and 3. Changelog

aleksei-burlakov commented 3 years ago

I have also added the tests.

aleksei-burlakov commented 3 years ago

@MalloZup , @Simranpal please review the last changes.