search

SUSE / salt-shaptools

Salt execution module and state to manage SAP Applications (HANA only at the moment) and SUSE Linux Enterprise High Availability components
Apache License 2.0
14 stars 11 forks source link

Remove --no-overwrite-sshkey: the option is deprecated #77

Closed aleksei-burlakov closed 3 years ago

aleksei-burlakov commented 3 years ago

The --no-overwrite-sshkey is deprecated. There are 2 commits in this PR, but only the last is relevant. The first commit will disappear when #74 is merged.

Jira reference: https://jira.suse.com/browse/TEAM-894

arbulu89 commented 3 years ago

@aleksei-burlakov As commented before. Please, don't increase the version number in the changelog. We will do that once we want to release, as we will get many changes at once.

aleksei-burlakov commented 3 years ago

I agree about the version number with xabi.

I would also like to have in the PR Description the motivation/rationale why the option no-overwrite is becoming depracted.

A part of that , looks good to me . Good work!

The motivation to remove the no-overwrite parameter is first because there is no need for it, second because it doesn't work. The first is somewhat speculative, one may say he really wants to have the cluster with the new ssh keys, though I can hardly imagine such a scenario. Initially, I guess, this argument was added just because this was the way how the crm cluster init worked. Now the crm doesn't overwrite the keys and I think this is very good. Second, there is a functionality in the habootstrap-formula that is supposed to overwrite the ssh keys using this option, but it didn't work properly (see https://github.com/SUSE/habootstrap-formula/pull/68#issuecomment-750064240)

aleksei-burlakov commented 3 years ago

@arbulu89 @MalloZup the version bump is reverted.