search

SUSE / ses-upgrade-helper

GNU General Public License v2.0
2 stars 2 forks source link

[DNM] upgrade-ses: add explicit switch for zypper auto agree with licenses #73

Closed ghost closed 7 years ago

ghost commented 7 years ago

Also a tiny bit of refactoring in zypper_dup(), removed an erroneous shift from the command line parsing, a bit of cleanup, and skip disable_restart_on_update() if /etc/syconfig/ceph does not exist.

smithfarm commented 7 years ago

This seems premature? Let's wait until Lars finds out if the explicit switch is really needed.

ghost commented 7 years ago

@smithfarm - It's just here in case we need it bsc#1011949#c14

Actually https://github.com/SUSE/ses-upgrade-helper/pull/73/commits/ac2164296ed2c6e95714f2fec21fb6767a8c170e and https://github.com/SUSE/ses-upgrade-helper/pull/73/commits/212b48b0a61e8c17513255e371cd9f5312407539 we need either way.

ghost commented 7 years ago

@smithfarm - DNM for now. Will rebase the actual "--auto-agree-with-licences" fix once https://github.com/SUSE/ses-upgrade-helper/pull/74 is in. Then we can merge this if/when given the green light. Sound good to you, Nathan?

smithfarm commented 7 years ago

@kmroz Yes :-) Please rebase.

ghost commented 7 years ago

@smithfarm - rebased for if/when we need it.

ghost commented 7 years ago

No longer applicable. Closing.