search

SUSE / skuba

CLI tool used to simplify (or orchestrate) kubeadm-based Kubernetes cluster deployment and update
Apache License 2.0
85 stars 57 forks source link

Re-render all addons base manifest during bootstrap (#1312) (backport to v4.2) #1434

Closed jenting closed 3 years ago

jenting commented 3 years ago

Why is this PR needed?

The metrics-server caBundle is not rendered when installing addon during bootstrap.

Fixes https://github.com/SUSE/avant-garde/issues/2042

What does this PR do?

When node bootstrap and prepare to install the addon, re-render and updates all local addons base manifest in order to updates resource which is known when bootstrap, like CA certificate information.

Anything else a reviewer needs to know?

N/A

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug. If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

N/A

Status BEFORE applying the patch

Fresh install a cluster, after finished, run kubectl top pods, it can't get the pods CPU/memory information.

Status AFTER applying the patch

Fresh install a cluster, after finished, run kubectl top pods, it can get the pods CPU/memory information.

Docs

N/A

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)