search

SUSE / skuba

CLI tool used to simplify (or orchestrate) kubeadm-based Kubernetes cluster deployment and update
Apache License 2.0
85 stars 57 forks source link

Fix detects new add-on manifest not exist #1464

Closed jenting closed 3 years ago

jenting commented 3 years ago

Why is this PR needed?

If there is a new add-on like kucero in the new Kubernetes version, the skuba CLI outputs unable to read kucero addon rendered template.

What does this PR do?

Advise the user to perform the skuba addon refresh localconfig if the local base manifest cannot find.

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug. If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

N/A

Status BEFORE applying the patch

  1. Deploy skuba 4.2.3.
  2. Build a new skuba CLI from this PR.
  3. Perform the skuba node upgrade.
  4. Run the skuba addon upgrade plan, the error message output on the console.

Status AFTER applying the patch

  1. Deploy skuba 4.2.3.
  2. Build a new skuba CLI from this PR.
  3. Perform the skuba node upgrade.
  4. Run the skuba addon upgrade plan, it'll advise the user to run skuba addon refresh localconfig.

Docs

N/A

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)
jenting commented 3 years ago

I'm not sure if this change is needed, according to my tests every time I have got. I am still trying reproduce original issue

I couldn't reproduce it with this PR before. :thinking: let me try to reproduce it.

mjura commented 3 years ago

I have restest it twice, and it seems that it is not required.

Every time I have got proper output to skuba addon refresh localconfig

jenting commented 3 years ago

I have restest it twice, and it seems that it is not required.

Every time I have got proper output to skuba addon refresh localconfig

okay, I'll close it first. Thanks for the testing @mjura.