search

SUSE / suse-migration-services

GNU General Public License v3.0
7 stars 11 forks source link

Fixed static method call #154

Closed schaefi closed 4 years ago

schaefi commented 4 years ago

The method is_registered is implemented as object method but is called as static method SUSEConnect.is_registered(). This is wrong and causes a python runtime error on missing argument: self

schaefi commented 4 years ago

I was testing the migration and it failed with

[INFO    ]: 10:05:24 | Update certificate pool
[ERROR   ]: 10:05:25 | Preparation of zypper metadata failed with is_registered() missing 1 required positional argument: 'self'

This is caused by the changes we did during the workshop. The patch provided here should fix it

rjschwei commented 4 years ago

LGTM

jesusbv commented 4 years ago

Good catch. LGTM.