Closed jesusbv closed 3 years ago
@jesusbv Thanks the implementation is good and will work. However I think we should make it a bit more flexible. What if another user wants to preserve some other file from /etc, then we need to add more code like this and have to run another submission which is an expensive/painful process as you know ;)
I was thinking about something like:
static:
- /etc/sysconfig/proxy
That way we would also support any static file to be preserved by a simple copy process.
Thoughts ?
static: - /etc/sysconfig/proxy
That way we would also support any static file to be preserved by a simple copy process.
Thoughts ?
I like the idea but I limited it to proxy
because I wasn't sure about the scope of the files we wanted to include.
Will update it.
yeah we can't be sure what people want/need to preserve more in the future but I think allowing this as a general feature is not a bad idea. Thanks for updating :+1:
Documentation will also need to be updated.
@jesusbv Just go ahead and merge after squash. NOTE: Please remember we need a bugzilla number for this to avoid trouble with maintenance. If there is no bugzilla report we can refer this to, please add a bug in bugzilla and use the number here in the commit message as "bsc#NR" Thanks much
Add option to preserve /etc/sysconfig/proxy file.
This fixes #180